This repository has been archived by the owner on Feb 5, 2019. It is now read-only.
Add support for DW_AT_main_subprogram #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like the Rust compiler to emit DW_AT_main_subprogram in its DWARF output, so that debuggers can find the user-provided main entry point. See rust-lang/rust#32620 This patch adds support for DW_AT_main_subprogram to LLVM to support this effort. A variant of this patch was accepted by upstream LLVM; there, DebugInfoFlags.def already has a flag with value 1<<20, which is why this patch uses 1<<21 -- this will avoid the need to change the Rust compiler when a new LLVM is imported.
|
Awesome! For reference, what's the upstream commit as well? |
|
Awesome, thanks! As a link to my future self -- llvm-mirror/llvm@d86b9f2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like the Rust compiler to emit DW_AT_main_subprogram in its DWARF
output, so that debuggers can find the user-provided main entry point.
See rust-lang/rust#32620
This patch adds support for DW_AT_main_subprogram to LLVM to support
this effort.
A variant of this patch was accepted by upstream LLVM; there,
DebugInfoFlags.def already has a flag with value 1<<20, which is why
this patch uses 1<<21 -- this will avoid the need to change the Rust
compiler when a new LLVM is imported.
I could not run the included test case with the rust fork of LLVM. There is a build failure - invalid C++ in some gtest. However, I did manage to run it against upstream LLVM; and I did test this patch by rebuilding my modified rustc against it.