Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added keywords to log and env_logger Cargo.toml #163

Merged
merged 1 commit into from May 24, 2017
Merged

Added keywords to log and env_logger Cargo.toml #163

merged 1 commit into from May 24, 2017

Conversation

budziq
Copy link
Contributor

@budziq budziq commented May 23, 2017

Hi,
I've added keywords = ["logger", "log", "logging"] to both log and env_logger.
These are the best I could came up with.

resolves #140

dtolnay
dtolnay reviewed May 23, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all mean the same thing. I would prefer to pick only one. Hopefully the ecosystem will standardize on whichever one we select here.

I recommend logging. All of the major players already have that tag.

@budziq
Copy link
Contributor Author

budziq commented May 24, 2017

done

@dtolnay dtolnay merged commit 8c08ef5 into rust-lang:master May 24, 2017
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
@passcod
Merge pull request rust-lang#163 from NobodyXu/optimization
7fa053c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add keywords to Cargo.toml
2 participants
@budziq @dtolnay