Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change html_root_url #168

Merged
merged 3 commits into from
May 24, 2017
Merged

change html_root_url #168

merged 3 commits into from
May 24, 2017

Conversation

morrme
Copy link
Contributor

@morrme morrme commented May 24, 2017

Closes #141

@morrme morrme mentioned this pull request May 24, 2017
Closed
dtolnay
dtolnay reviewed May 24, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unfortunately for now you actually have to write the crate and version in the link. See serde-rs/serde@dc7ab26 for an example. Please also add a reminder in Cargo.toml like the one in that commit.

@dtolnay dtolnay merged commit eea9cb2 into rust-lang:master May 24, 2017
@dtolnay dtolnay mentioned this pull request Jul 18, 2017
Closed
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
@passcod
Merge pull request rust-lang#168 from NobodyXu/feature/avoid-oom
29b28a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morrme @dtolnay