Dynamically track the 'static-ness of record strings #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logger implementations commonly need to convert a `Record` into a non-borrowed form to e.g. log it asynchronously on a separate thread. This allows them to avoid having to allocate owned `String`s for the module path and file fields, which will in practice almost always be `'static`. cc rust-lang#206
sfackler
commented
Jul 27, 2019
| @@ -669,6 +669,22 @@ impl LevelFilter { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Debug)] | |||
There was a problem hiding this comment.
Not sure if we want equality, etc to consider staticness or not. It seems a bit weird for text to not be equal to itself depending on the lifetime, but at the same time it does affect how the Record behaves.
There was a problem hiding this comment.
Since this is publicly unreachable it seems ok to me. If we ever did want to expose some string-like type we could think about it then?
KodrAus
approved these changes
Jul 28, 2019
| @@ -669,6 +669,22 @@ impl LevelFilter { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Debug)] | |||
There was a problem hiding this comment.
Since this is publicly unreachable it seems ok to me. If we ever did want to expose some string-like type we could think about it then?
|
I'll put together another patch release, since it sounds like this could be blocking folks. |
EFanZh
pushed a commit
to EFanZh/log
that referenced
this pull request
Jul 23, 2023
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logger implementations commonly need to convert a
Recordinto anon-borrowed form to e.g. log it asynchronously on a separate thread.
This allows them to avoid having to allocate owned
Strings for themodule path and file fields, which will in practice almost always be
'static.cc #206
r? @KodrAus