Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ACE for editing #247

Closed
steveklabnik opened this issue Apr 5, 2017 · 3 comments
Closed

Integrate ACE for editing #247

steveklabnik opened this issue Apr 5, 2017 · 3 comments
Labels
A-JavaScript Area: Javascript C-enhancement Category: Enhancement or feature request S-Experiment Status: Experiment

Comments

@steveklabnik
Copy link
Member

This is the last thing needed to get Rust By Example over to mdbook.

I did some work on this today, and it seems like ACE clashes with something else we're doing; the divs just don't show up.

@azerupi azerupi added A-JavaScript Area: Javascript S-Experiment Status: Experiment C-enhancement Category: Enhancement or feature request and removed Type: Enhancement labels May 15, 2017
@azerupi
Copy link
Contributor

azerupi commented May 15, 2017

If ACE is integrated, it should be optional with a key in the config. It's too large of a dependency to impose on all users.

@projektir
Copy link
Contributor

I've been poking at trying to add Ace to playpens for a bit. Since this is about adding features to mdBook, it would help knowing what mdBook's overall goals are, and this is my first time looking at this repo.

@azerupi does mdBook have interest in implementing editing functionality in the general case? I've seen what appears to be a dormant flag editable in the code. If mdBook does not want to use Ace for this, what are the other options?

It's too large of a dependency to impose on all users.

mdBook currently has highlight.js as a dependency, which is not too light (although it can be reduced to basically nothing if a version for just Rust is grabbed). Ace is heavier, but would make highlight.js unnecessary. Right now, Ace will not work inside playpens because highlight.js seems to grab events on code blocks.

@azerupi
Copy link
Contributor

azerupi commented Jun 1, 2017

does mdBook have interest in implementing editing functionality in the general case?

As an opt-in feature, yes. It is not something I want to force on all users if they don't need it.

mdBook currently has highlight.js as a dependency, which is not too light

Indeed, in the long run I was planning to take a look at syntect as an alternative in order to move syntax highlighting to the book generation phase. But that is not for right now.

@azerupi azerupi added this to the Rust By Example milestone Jun 1, 2017
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-JavaScript Area: Javascript C-enhancement Category: Enhancement or feature request S-Experiment Status: Experiment
Projects
None yet
Development

No branches or pull requests

3 participants