-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for publishing v0.0.2 to crates.io #59
Comments
Nothing obvious beside this:
I'm not sure how to fix this... |
I can not reproduce this issue on Chrome, are you using Firefox? |
Yeah. I don't have chrome installed. Back just doesn't trigger refresh I guess so it returns to the way the previous page was (which shouldn't be accurate anymore regardless...). |
ok, I am not sure I can do anything about that on my side though |
You're right. Chrome doesn't do that. It works fine with gitbook so it looks like there is some way to deal with it. Changing the theme does the same thing. Odd |
They say firefox triggers onload() on back. Are themes and sidebars adjusted at onload? I haven't checked yet. |
It seems to be a cache problem. When hitting back, Firefox reloads the page from cache like it was before leaving. This means that all the javascript has been executed and will not run a second time. I found a good explanation in this StackOverflow answer |
Could you try again in a couple of minutes, when the new commit has been deployed? |
You can also seem to fix it via manually calling the pageshow event |
Yeah, it works perfectly now. There probably should be a dedicated before pageload script. Then, instead of rerunning everything, you can just reset all localstorage settings on pageshow. |
I am glad it works, I will leave it like this for now. But feel free to make a new issue so that I remember to experiment and improve this for the next versions :) |
Sure |
I think it's time to publish a new version to crates.io, there have been a lot of improvements since v0.0.1.
@mdinger if you find any last minute bugs to fix before publishing to crates.io, let me know ;)
The text was updated successfully, but these errors were encountered: