Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for publishing v0.0.2 to crates.io #59

Closed
3 tasks done
azerupi opened this issue Sep 24, 2015 · 12 comments
Closed
3 tasks done

Prepare for publishing v0.0.2 to crates.io #59

azerupi opened this issue Sep 24, 2015 · 12 comments
Milestone

Comments

@azerupi
Copy link
Contributor

azerupi commented Sep 24, 2015

I think it's time to publish a new version to crates.io, there have been a lot of improvements since v0.0.1.

  • Check if the docs are still up to date
  • Regenerate css before publishing
  • Publish to crates.io

@mdinger if you find any last minute bugs to fix before publishing to crates.io, let me know ;)

@azerupi azerupi added this to the 0.0.2 milestone Sep 24, 2015
@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

Nothing obvious beside this:

  1. Go to formatting and leave sidebar enabled
  2. Go to the next page
  3. Close the sidebar
  4. Click back on the browser
  5. The sidebar returns until you refresh

I'm not sure how to fix this...

@azerupi
Copy link
Contributor Author

azerupi commented Sep 24, 2015

I can not reproduce this issue on Chrome, are you using Firefox?

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

Yeah. I don't have chrome installed. Back just doesn't trigger refresh I guess so it returns to the way the previous page was (which shouldn't be accurate anymore regardless...).

@azerupi
Copy link
Contributor Author

azerupi commented Sep 24, 2015

ok, I am not sure I can do anything about that on my side though

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

You're right. Chrome doesn't do that. It works fine with gitbook so it looks like there is some way to deal with it. Changing the theme does the same thing. Odd

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

They say firefox triggers onload() on back. Are themes and sidebars adjusted at onload? I haven't checked yet.

@azerupi
Copy link
Contributor Author

azerupi commented Sep 24, 2015

It seems to be a cache problem. When hitting back, Firefox reloads the page from cache like it was before leaving. This means that all the javascript has been executed and will not run a second time.

I found a good explanation in this StackOverflow answer

azerupi added a commit that referenced this issue Sep 24, 2015
@azerupi
Copy link
Contributor Author

azerupi commented Sep 24, 2015

Could you try again in a couple of minutes, when the new commit has been deployed?

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

You can also seem to fix it via manually calling the pageshow event

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

Yeah, it works perfectly now. There probably should be a dedicated before pageload script. Then, instead of rerunning everything, you can just reset all localstorage settings on pageshow.

@azerupi
Copy link
Contributor Author

azerupi commented Sep 24, 2015

I am glad it works, I will leave it like this for now. But feel free to make a new issue so that I remember to experiment and improve this for the next versions :)

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants