Add CSS scroll-margin-top to headings which contain link targets.
#1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means when the link is followed, the page scrolls in such a way as to leave space for the fixed menu bar. Fixes rust-lang#1040
ehuss
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
Thanks! This has really been annoying me.
Unfortunately it doesn't seem to work on Safari. Initially I thought it was because it still uses the old name of scroll-snap-margin, but using that didn't help. I was also wondering if maybe it was because the scroll-snap-type is none for the container, but nothing I did seemed to get it to work.
I also went down the rabbit hole of looking at alternatives (1, 2, 3, 4), but none of them seem to work very well. Why do these things have to be so difficult?
Anyway, I'm fine with this until someone can come up with a better solution. I'm also fine with the padding even when the menu bar isn't visible (I kinda prefer a little padding).
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Add CSS `scroll-margin-top` to headings which contain link targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1040 "Menu bar covers section header on anchor links".
I haven't attempted to make the new margin not apply in cases where the top menu bar won't be visible.
I've tested it on desktop Firefox and Chromium.
The second commit adds a CSS variable for the menu-bar height, to make it less likely that the scroll-margin-top value will become outdated if someone changes the design.