Assure copy_files_except_ext(..) won't copy directories into itself
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents recursive copy-loops when the destination directory is contained in the source directory. Now it bails out with a descriptive error message.
azerupi
approved these changes
Feb 29, 2020
Closed
ehuss
added a commit
to ehuss/mdBook
that referenced
this pull request
Apr 3, 2020
…itself (rust-lang#1135)" This reverts commit d7a2b29.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
…ust-lang#1135) This prevents recursive copy-loops when the destination directory is contained in the source directory. Now it bails out with a descriptive error message.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
…itself (rust-lang#1135)" (rust-lang#1181) This reverts commit 104dc67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents recursive copy-loops when the destination directory
is contained in the source directory.
Now it bails out with a descriptive error message.