Add SVG favicon. #1230
Merged
Add SVG favicon. #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elinvynia
reviewed
Jun 22, 2020
| @@ -415,7 +416,6 @@ fn make_data( | |||
| "description".to_owned(), | |||
| json!(config.book.description.clone().unwrap_or_default()), | |||
| ); | |||
| data.insert("favicon".to_owned(), json!("favicon.png")); | |||
There was a problem hiding this comment.
Shouldn't this also somehow be replaced?
There was a problem hiding this comment.
In index.hbs I replaced {{ favicon }} with just the literal text favicon.png and favicon.svg. There didn't seem to be a reason to have this because it is a fixed value and is not configurable.
Elinvynia
approved these changes
Jun 22, 2020
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Add SVG favicon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an SVG favicon which inverts on browsers/operating systems that support "dark" media query.
Dark:
Light:
This doesn't really work on Safari, which has it's own collection of images I'm not in the mood to add. Mostly tested with Firefox and Chrome, Windows and macOS. My Linux system doesn't seem to have a dark/light switch I can easily find.
Closes #1223
Closes #1219