Fix some issues with fragment scrolling and linking. #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with how
#fragment scrolling works, and how headers are highlighted::targetelements now scroll into view with a top margin so that they aren't covered by the menu bar. This affected anything that wasn't h1-h4 (like h5, h6, footnotes, custom anchors, etc.). I didn't see an obvious reason to restrict this to just header tags, so it now selects all:targetelements.Note that the margin scrolling does not work on Safari, but has been fixed in Technology Preview 117 (which I think is Safari 14.2). This required moving the
idfrom the<a>tag to the header tag, which I think should be fine (Safari didn't seem to like id's on<a>tags).Fixes #1198
Fixes #1357