switch from open to opener #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `opener` launches the subprocess without waiting for its completion, compared to `open` which waits for its completion. This is helpful in case the `watch` feature is enabled and one of the following commands `watch | serve --open` is used. If this command would open the browser, listening for changes would be blocked by the browser.
ehuss
force-pushed
the
switch-to-opener-crate
branch
from
6b1aaee
to
ff4b8e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
openerlaunches the subprocess without waiting for itscompletion, compared to
openwhich waits for its completion.This is helpful in case the
watchfeature is enabled and one of thefollowing commands
watch | serve --openis used. If this command wouldopen the browser, listening for changes would be blocked by the browser.
This fixes #1639.