Fix code padding in headings #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Jul 13, 2022
src/theme/css/chrome.css
Outdated
| @@ -252,7 +252,7 @@ pre > .buttons button { | |||
| padding: 0.3rem 1rem; | |||
| } | |||
| } | |||
| code { | |||
| p code { | |||
There was a problem hiding this comment.
This doesn't look quite right to me. This padding should only be applied to code blocks which have the form:
<pre><code>…</code></pre>
p code would apply to almost everything except code blocks.
It seems to me that the rule should be something like:
Suggested change
| p code { | |
| pre > code { |
(which also matches the other nearby rules.)
There was a problem hiding this comment.
Ah, sorry I misunderstood the original PR. I've changed it to your suggestion, and amended it to the old commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1806, extra padding was added to code blocks, but this adds the padding to headings as well. I think this was only meant to affect code blocks in the main content. If spacing was intended in the headings, a margin would probably be better. This PR just limits the scope of the change from #1806.
With this PR:
Before
After