Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning check for theme directory as ./src/theme #2263

Merged
merged 1 commit into from Dec 10, 2023
Merged

Remove warning check for theme directory as ./src/theme #2263

merged 1 commit into from Dec 10, 2023

Conversation

jhult
Copy link
Contributor

@jhult jhult commented Dec 9, 2023

This was causing an unnecessary warning if &src_dir was the same as ctx.root.

Also, this code had a TODO to "remove some time after the 0.1.8 release".

@jhult
Remove warning check for theme directory as ./src/theme
91af1c3 
This was causing an unnecessary warning if &src_dir was the same as ctx.root
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Dec 9, 2023
@Dylan-DPC
Copy link
Member

Thanks

@Dylan-DPC Dylan-DPC added this pull request to the merge queue Dec 10, 2023
Merged via the queue into rust-lang:master with commit c1d622e Dec 10, 2023
8 checks passed
@jhult jhult deleted the theme-dir-warning-check branch December 10, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhult @Dylan-DPC @rustbot