Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dividers being folded by sections #2364

Merged
merged 1 commit into from
May 14, 2024

Conversation

expikr
Copy link
Contributor

@expikr expikr commented Apr 16, 2024

fixes #2362
fixes #733

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Apr 16, 2024
@expikr expikr marked this pull request as ready for review April 17, 2024 07:14
The spacer was incorrectly being included in the previous fold.
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm still not 100% certain if this won't have some unexpected interaction, but I can't think of any. I'm not quite clear if it was done this way intentionally in the first place. I think it's good to go ahead and merge, and see if there are any reports of issues.

@ehuss ehuss added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot merged commit cb0a992 into rust-lang:master May 14, 2024
8 checks passed
@expikr expikr deleted the patch-3 branch May 15, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: separator gets folded by subsection Spacers in sidebar don't appear at correct level
3 participants