Optimize search index #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(travis failure is due to cache uploading, not tests) |
mattico
force-pushed
the
search-index-opt
branch
from
6ca68e4
to
6a5be34
Compare
This change reduced the searchindex.js of book_example from 508KB to 317KB.
This allows the search index to be loaded asynchronously, and should use fewer resources as it doesn't have to execute the JS. JS loading is kept as a fallback for CORS issues with file:// URIs in Chrome.
mattico
force-pushed
the
search-index-opt
branch
from
6a5be34
to
384582a
Compare
mattico
added a commit
to mattico/mdBook
that referenced
this pull request
Jul 26, 2018
which should have been included in rust-lang#707
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Optimize search index
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
which should have been included in rust-lang#707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #704