Change overflow-x to initial #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change overflow-x from auto to initial. This resolves weird rendering behavior in Chrome and Safari on macOS. With help from @bash Co-authored-by: Ruben Schmidmeister <ruben.schmidmeister@icloud.com>
ehuss
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
This seems to fix the issue for me, tried on a few different browsers.
I would prefer a comment explaining why this is here. I'm not a fan of reverse-engineering convoluted CSS.
The issue here is that the highlight.js theme has a hljs class which sets overflow-x to auto to display horizontal scroll bars when a code block is too wide. mdBook uses hljs for inline code blocks, too, but this auto setting can cause problems. Setting it to initial (which is the default "visible") seems to fix it.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Change overflow-x from auto to initial. This resolves weird rendering behavior in Chrome and Safari on macOS. With help from @bash Co-authored-by: Ruben Schmidmeister <ruben.schmidmeister@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves weird rendering behavior in Chrome and Safari on macOS.
Before
After