Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add navigation by arrows #87

Merged
merged 1 commit into from Dec 30, 2015
Merged

Conversation

funkill
Copy link
Contributor

@funkill funkill commented Dec 30, 2015

No description provided.

azerupi added a commit that referenced this pull request Dec 30, 2015
@azerupi azerupi merged commit 41462e8 into rust-lang:master Dec 30, 2015
@azerupi
Copy link
Contributor

azerupi commented Dec 30, 2015

Thanks! :)

switch (e.keyCode) {
case KEY_CODES.NEXT_KEY:
e.preventDefault();
window.location.href = $('.nav-chapters.next').attr('href');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it, but you have to check that it actually exists. Because when you are on the first page and then press left arrow you get undefined and that page does not exist. I will fix it now ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants