Fix keyboard chapter navigation for file urls.
#915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes it so that keyboard navigation should work when loading a book from a
file://url.When loading the search index, if it fails due to a CORS error (such as when loading json from
file://), it will load thesearchindex.jsversion instead here. However, this was written to replace thewindow.searchobject which loses thehasFocusmethod which caused the keyboard handler to fail becausehasFocuswas missing.This changes it so that instead of replacing
window.search, it just updates the existing object.Fixes #910.