Address some review nits

rust-lang · Apr 21, 2022 · d766294 · d766294
1 parent cd86199
commit d766294
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 22 deletions.
diff --git a/src/helpers.rs b/src/helpers.rs
@@ -772,12 +772,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
         let this = self.eval_context_mut();
         // This got just allocated, so there definitely is a pointer here.
         let provenance = mplace.ptr.into_pointer_or_addr().unwrap().provenance;
-
-        if let Tag::Concrete(concrete) = provenance {
-            this.alloc_mark_immutable(concrete.alloc_id).unwrap();
-        } else {
-            bug!("Machine allocation that was just created should have concrete provenance");
-        }
+        this.alloc_mark_immutable(provenance.get_alloc_id().unwrap()).unwrap();
     }
 }
 

diff --git a/src/intptrcast.rs b/src/intptrcast.rs
@@ -58,15 +58,7 @@ impl<'mir, 'tcx> GlobalStateInner {
         let pos = global_state.int_to_ptr_map.binary_search_by_key(&addr, |(addr, _)| *addr);
 
         match pos {
-            Ok(pos) => {
-                let (_, alloc_id) = global_state.int_to_ptr_map[pos];
-
-                if !global_state.permissive_provenance || global_state.exposed.contains(&alloc_id) {
-                    Some(global_state.int_to_ptr_map[pos].1)
-                } else {
-                    None
-                }
-            }
+            Ok(pos) => Some(global_state.int_to_ptr_map[pos].1),
             Err(0) => None,
             Err(pos) => {
                 // This is the largest of the adresses smaller than `int`,
@@ -76,20 +68,26 @@ impl<'mir, 'tcx> GlobalStateInner {
                 let offset = addr - glb;
                 // If the offset exceeds the size of the allocation, don't use this `alloc_id`.
 
-                if (!global_state.permissive_provenance || global_state.exposed.contains(&alloc_id))
-                    && offset
-                        <= ecx
-                            .get_alloc_size_and_align(alloc_id, AllocCheck::MaybeDead)
-                            .unwrap()
-                            .0
-                            .bytes()
+                if offset
+                    <= ecx
+                        .get_alloc_size_and_align(alloc_id, AllocCheck::MaybeDead)
+                        .unwrap()
+                        .0
+                        .bytes()
                 {
                     Some(alloc_id)
                 } else {
                     None
                 }
             }
         }
+        .and_then(|alloc_id| {
+            if global_state.permissive_provenance && !global_state.exposed.contains(&alloc_id) {
+                None
+            } else {
+                Some(alloc_id)
+            }
+        })
     }
 
     pub fn expose_addr(ecx: &MiriEvalContext<'mir, 'tcx>, alloc_id: AllocId) {