Skip to content

Commit

Permalink
Auto merge of #1639 - m-ou-se:allocator, r=RalfJung
Browse files Browse the repository at this point in the history
Update to new core::alloc::Allocator interface

This fixes the allocator test for the changes made to the allocator trait in `core` in rust-lang/rust#79286

See rust-lang/rust#79709
  • Loading branch information
bors committed Dec 5, 2020
2 parents 47acece + de5b26d commit e54c5db
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion rust-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
88b81970ba7a989a728b32039dd075dc206f1360
3ff10e74a74ed093fcabac1de27fe1cd65bbbb4a
22 changes: 11 additions & 11 deletions tests/run-pass/heap_allocator.rs
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
#![feature(allocator_api, slice_ptr_get)]

use std::ptr::NonNull;
use std::alloc::{Global, AllocRef, Layout, System};
use std::alloc::{Global, Allocator, Layout, System};
use std::slice;

fn check_alloc<T: AllocRef>(allocator: T) { unsafe {
fn check_alloc<T: Allocator>(allocator: T) { unsafe {
for &align in &[4, 8, 16, 32] {
let layout_20 = Layout::from_size_align(20, align).unwrap();
let layout_40 = Layout::from_size_align(40, 4*align).unwrap();
let layout_10 = Layout::from_size_align(10, align/2).unwrap();

for _ in 0..32 {
let a = allocator.alloc(layout_20).unwrap().as_non_null_ptr();
let a = allocator.allocate(layout_20).unwrap().as_non_null_ptr();
assert_eq!(a.as_ptr() as usize % layout_20.align(), 0, "pointer is incorrectly aligned");
allocator.dealloc(a, layout_20);
allocator.deallocate(a, layout_20);
}

let p1 = allocator.alloc_zeroed(layout_20).unwrap().as_non_null_ptr();
let p1 = allocator.allocate_zeroed(layout_20).unwrap().as_non_null_ptr();
assert_eq!(p1.as_ptr() as usize % layout_20.align(), 0, "pointer is incorrectly aligned");
assert_eq!(*p1.as_ptr(), 0);

Expand All @@ -38,17 +38,17 @@ fn check_alloc<T: AllocRef>(allocator: T) { unsafe {
let slice = slice::from_raw_parts(p4.as_ptr(), 10);
assert_eq!(&slice, &[0_u8; 10]);

allocator.dealloc(p4, layout_10);
allocator.deallocate(p4, layout_10);
}
} }

fn check_align_requests<T: AllocRef>(allocator: T) {
fn check_align_requests<T: Allocator>(allocator: T) {
for &size in &[2, 8, 64] { // size less than and bigger than alignment
for &align in &[4, 8, 16, 32] { // Be sure to cover less than and bigger than `MIN_ALIGN` for all architectures
let iterations = 32;
unsafe {
let pointers: Vec<_> = (0..iterations).map(|_| {
allocator.alloc(Layout::from_size_align(size, align).unwrap()).unwrap().as_non_null_ptr()
allocator.allocate(Layout::from_size_align(size, align).unwrap()).unwrap().as_non_null_ptr()
}).collect();
for &ptr in &pointers {
assert_eq!((ptr.as_ptr() as usize) % align, 0,
Expand All @@ -57,7 +57,7 @@ fn check_align_requests<T: AllocRef>(allocator: T) {

// Clean up.
for &ptr in &pointers {
allocator.dealloc(ptr, Layout::from_size_align(size, align).unwrap())
allocator.deallocate(ptr, Layout::from_size_align(size, align).unwrap())
}
}
}
Expand All @@ -69,7 +69,7 @@ fn global_to_box() {
let l = Layout::new::<T>();
// allocate manually with global allocator, then turn into Box and free there
unsafe {
let ptr = Global.alloc(l).unwrap().as_non_null_ptr().as_ptr() as *mut T;
let ptr = Global.allocate(l).unwrap().as_non_null_ptr().as_ptr() as *mut T;
let b = Box::from_raw(ptr);
drop(b);
}
Expand All @@ -82,7 +82,7 @@ fn box_to_global() {
unsafe {
let b = Box::new(T::default());
let ptr = Box::into_raw(b);
Global.dealloc(NonNull::new(ptr as *mut u8).unwrap(), l);
Global.deallocate(NonNull::new(ptr as *mut u8).unwrap(), l);
}
}

Expand Down

0 comments on commit e54c5db

Please sign in to comment.