Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignoring alignment violations #1326

Closed
shepmaster opened this issue Apr 12, 2020 · 0 comments · Fixed by #1332
Closed

Allow ignoring alignment violations #1326

shepmaster opened this issue Apr 12, 2020 · 0 comments · Fixed by #1332
Labels
A-interpreter Area: affects the core interpreter C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@shepmaster
Copy link
Member

Talking with @RalfJung, they suggested that Miri could learn a flag like -Zmiri-ignore-alignment.

The broader context is that I was basically asking about suppressions (see #788), so that I could ignore errors from a dependency and see if my code introduced any additional errors. The specific errors from the dependency were alignment-related, and @RalfJung pointed out that there's the possibility of false positives.
@RalfJung RalfJung added A-interpreter Area: affects the core interpreter C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Apr 12, 2020
@RalfJung RalfJung mentioned this issue Apr 13, 2020
Merged
bors added a commit that referenced this issue Apr 14, 2020
@bors
Auto merge of #1332 - RalfJung:disable-alignment-check, r=RalfJung
e7ab430 
Add option to disable alignment check

Requires rust-lang/rust#71101
Fixes #1326
@bors bors closed this as completed in 0371590 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-interpreter Area: affects the core interpreter C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to disable alignment check RalfJung/miri
2 participants
@shepmaster @RalfJung