Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate -Zmiri-allow-ptr-int-transmute? #2188

Closed
RalfJung opened this issue Jun 4, 2022 · 0 comments · Fixed by rust-lang/rust#99644
Closed

Deprecate -Zmiri-allow-ptr-int-transmute? #2188

RalfJung opened this issue Jun 4, 2022 · 0 comments · Fixed by rust-lang/rust#99644
Labels
A-interpreter Area: affects the core interpreter A-intptrcast Area: affects int2ptr and ptr2int casts C-cleanup Category: cleaning up our code

Comments

@RalfJung
Copy link
Member

RalfJung commented Jun 4, 2022

I would love to deprecate and remove -Zmiri-allow-ptr-int-transmute sooner rather than later. That would let us do some nice cleanup in the interpreter: we could remove the ptr_from_addr_transmute hook, which means scalar_to_ptr does not need access to the InterpCx any more, so we can just make it a method on Scalar.
@RalfJung RalfJung added A-interpreter Area: affects the core interpreter A-intptrcast Area: affects int2ptr and ptr2int casts C-cleanup Category: cleaning up our code labels Jun 5, 2022
This was referenced Jun 6, 2022
Merged
Closed
bors added a commit that referenced this issue Jun 13, 2022
@bors
Auto merge of #2203 - RalfJung:deprecate, r=oli-obk
2bbb70f 
deprecate -Zmiri-allow-uninit-numbers and -Zmiri-allow-ptr-int-transmute

Cc #2187 #2188
@RalfJung RalfJung mentioned this issue Jul 9, 2022
Merged
bors added a commit that referenced this issue Jul 19, 2022
@bors
Auto merge of #2350 - RalfJung:remove-deprecated, r=oli-obk
8757d86 
remove deprecated options

These have been deprecated a month ago and nobody said they need them. Is that enough time? We can also let this PR sit a little.

Cc #2187 #2188
(keeping them open to track removing their supporting infrastructure in the core interpreter)
@RalfJung RalfJung mentioned this issue Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-interpreter Area: affects the core interpreter A-intptrcast Area: affects int2ptr and ptr2int casts C-cleanup Category: cleaning up our code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove some provenance-related machine hooks that Miri no longer needs RalfJung/rust
1 participant
@RalfJung