Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Change back to stable toolchain #828

Closed
tesuji opened this issue Jul 5, 2019 · 3 comments
Closed

CI: Change back to stable toolchain #828

tesuji opened this issue Jul 5, 2019 · 3 comments
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@tesuji
Copy link
Contributor

tesuji commented Jul 5, 2019

PR #827 changed default CI toolchain to beta to sort out cargo warning
for cargo feature default-run. We should revert it back when we done
dealing with latest rustc.
@tesuji tesuji mentioned this issue Jul 5, 2019
Merged
@RalfJung
Copy link
Member

RalfJung commented Jul 5, 2019

We should revert it back when we done dealing with latest rustc.

Correction: we can only revert it back once Rust 1.37 hits stable.

@RalfJung RalfJung added A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Jul 5, 2019
@RalfJung
Copy link
Member

RalfJung commented Jul 6, 2019

Actually, thinking about it, using the beta compiler seems like a nice idea. That's very close to the version rustc uses for bootstrapping, which is good -- that's the cargo version used in rustc CI.

@tesuji
Copy link
Contributor Author

tesuji commented Jul 6, 2019

This could be closed now.

@tesuji tesuji closed this as completed Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @tesuji