Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use harness = false instead of #![feature(custom_test_frameworks)] #1784

Merged
merged 1 commit into from May 1, 2021
Merged

Use harness = false instead of #![feature(custom_test_frameworks)] #1784

merged 1 commit into from May 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2021

Quoting from the comment in tests/compiletest.rs:

Custom test runner, to avoid libtest being wrapped around compiletest which wraps libtest.

I believe harness = false is more suitable for that purpose.

I have verified that both ./miri test and LD_LIBRARY_PATH=$PWD/build/x86_64-unknown-linux-gnu/stage2/lib PATH=$PWD/build/bin:$PATH ./x.py test src/tools/miri work well.

@RalfJung
Copy link
Member

RalfJung commented May 1, 2021

Much better, thanks. :-)
@bors r+

@bors
Copy link
Collaborator

bors commented May 1, 2021

📌 Commit 2da6bed has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented May 1, 2021

⌛ Testing commit 2da6bed with merge 0e30385...

@bors
Copy link
Collaborator

bors commented May 1, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 0e30385 to master...

@bors bors merged commit 0e30385 into rust-lang:master May 1, 2021
@ghost ghost deleted the harness-false branch May 3, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants