Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checking os_family #1786

Merged
merged 2 commits into from
May 3, 2021
Merged

fix checking os_family #1786

merged 2 commits into from
May 3, 2021

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 3, 2021

@RalfJung
Copy link
Member Author

RalfJung commented May 3, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented May 3, 2021

📌 Commit aac6e2a has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented May 3, 2021

⌛ Testing commit aac6e2a with merge 44db1fd...

bors added a commit that referenced this pull request May 3, 2021
@bors
Copy link
Collaborator

bors commented May 3, 2021

💔 Test failed - checks-actions

@ghost
Copy link

ghost commented May 3, 2021

error: unsupported operation: can't call foreign function: llvm.aarch64.isb
  --> /usr/share/rust/.rustup/toolchains/master/lib/rustlib/src/rust/library/core/src/../../stdarch/crates/core_arch/src/acle/barrier/common.rs:12:9
   |
12 |         super::isb(super::arg::SY)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't call foreign function: llvm.aarch64.isb
   |
   = help: this is likely not a bug in the program; it indicates that the program performed an operation that the interpreter does not support
           
   = note: inside `<std::arch::aarch64::SY as core::core_arch::acle::sealed::Isb>::__isb` at /usr/share/rust/.rustup/toolchains/master/lib/rustlib/src/rust/library/core/src/../../stdarch/crates/core_arch/src/acle/barrier/common.rs:12:9
   = note: inside `std::arch::aarch64::__isb::<std::arch::aarch64::SY>` at /usr/share/rust/.rustup/toolchains/master/lib/rustlib/src/rust/library/core/src/../../stdarch/crates/core_arch/src/acle/barrier/mod.rs:122:5
   = note: inside `std::hint::spin_loop` at /usr/share/rust/.rustup/toolchains/master/lib/rustlib/src/rust/library/core/src/hint.rs:131:22
   = note: inside `std::sync::atomic::spin_loop_hint` at /usr/share/rust/.rustup/toolchains/master/lib/rustlib/src/rust/library/core/src/sync/atomic.rs:2790:5
note: inside `test_spin_loop_hint` at $DIR/sync_singlethread.rs:54:5
  --> $DIR/sync_singlethread.rs:54:5
   |
54 |     atomic::spin_loop_hint();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `main` at $DIR/sync_singlethread.rs:8:5
  --> $DIR/sync_singlethread.rs:8:5
   |
8  |     test_spin_loop_hint();
   |     ^^^^^^^^^^^^^^^^^^^^^
   = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /usr/share/rust/.rustup/toolchains/master/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5

Probably due to rust-lang/rust#84725.

@RalfJung
Copy link
Member Author

RalfJung commented May 3, 2021

Yes that seems to be it, thanks for digging that out!
@bors r+

@bors
Copy link
Collaborator

bors commented May 3, 2021

📌 Commit c3ae8a6 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented May 3, 2021

⌛ Testing commit c3ae8a6 with merge 43ae314...

@bors
Copy link
Collaborator

bors commented May 3, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 43ae314 to master...

@bors bors merged commit 43ae314 into rust-lang:master May 3, 2021
@RalfJung RalfJung deleted the rustup branch May 3, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants