tests for Box with non-ZST allocator #2072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
box-alloc
branch
2 times, most recently
from
e2cfa37
to
21e34fa
Compare
RalfJung
changed the title
|
I tried this with rust-lang/rust#95576 and it looks like it fixes dereferencing. Of course, unsizing is still broken. |
|
Ah, good point. I wonder what the codegen backends do for unsizing. |
|
Now that rust-lang/rust#95576 has been merged, it's just the unsizing that's left. |
|
Miri's type validation also still bails on these non-primitive Stacked Borrows retagging will probably have similar issues. |
|
I am closing this for now since I think we need a larger redesign of |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 29, 2022
…ial, r=RalfJung Fix box with custom allocator in miri This should fix the failures in rust-lang/miri#2072 and rust-lang#98510. cc `@RalfJung`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 29, 2022
…ial, r=RalfJung Fix box with custom allocator in miri This should fix the failures in rust-lang/miri#2072 and rust-lang#98510. cc ``@RalfJung``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 29, 2022
…ial, r=RalfJung Fix box with custom allocator in miri This should fix the failures in rust-lang/miri#2072 and rust-lang#98510. cc ```@RalfJung```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs something like rust-lang/rust#96198 (+more for the unsizing stuff), or hopefully rust-lang/rust#95576 suffices as well.