Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the correct size to the AllocRange for log_creation #2128

Merged
merged 1 commit into from
May 19, 2022

Conversation

saethlin
Copy link
Member

Fixes #2127

I guess all I needed was a bit of sleep and reassurance that this diagnostic is the wrong part of that situation.

@RalfJung
Copy link
Member

Ah, makes sense. Did you check the other alloc_range calls in the file for similar problems?

Is there any way we can add a regression test for this?

@saethlin
Copy link
Member Author

I did glance over the other calls and I didn't notice this mistake anywhere else.

I actually don't know if we already have a test for this, because the current tests don't check much of the output and there are a lot of them. Would the UI tests help with at least checking the contents of the diagnostics?

@oli-obk
Copy link
Contributor

oli-obk commented May 19, 2022

Would the UI tests help with at least checking the contents of the diagnostics?

I had to filter them pretty heavily to make them platform independent, so likely all the numbers will be gone

@RalfJung
Copy link
Member

Can we use //~ HELP to match on them?

@oli-obk
Copy link
Contributor

oli-obk commented May 19, 2022

Can we use //~ HELP to match on them?

right now these also see the filtered version. That can be fixed tho

@RalfJung
Copy link
Member

Okay.

Let's merge this now then, but keep the issue open to track adding a test.
@bors r+

@bors
Copy link
Collaborator

bors commented May 19, 2022

📌 Commit ada864f has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented May 19, 2022

⌛ Testing commit ada864f with merge 9230b92...

@bors
Copy link
Collaborator

bors commented May 19, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 9230b92 to master...

@bors bors merged commit 9230b92 into rust-lang:master May 19, 2022
@saethlin saethlin deleted the fix-creation-range branch July 3, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong/misleading diagnostic in matrixmultiply==0.3.2
4 participants