avoid copying thread manager state in data race detector #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
datarace
branch
2 times, most recently
from
15e117d
to
86a2bf4
Compare
|
@bors r+ |
|
📌 Commit 86a2bf4 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 1, 2022
avoid copying thread manager state in data race detector When doing #2047 I did not realize that there is some redundant state here that we can now remove from the data race detector. Also this removes the vector clocks from the data race errors since those don't really help diagnose the problem.
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
📌 Commit d09db16 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing #2047 I did not realize that there is some redundant state here that we can now remove from the data race detector.
Also this removes the vector clocks from the data race errors since those don't really help diagnose the problem.