Use ui_test from crates.io instead of having it in-tree #2449
Conversation
|
Hmm weird, it picked up the commits twice. I need to investigate. |
oli-obk
force-pushed
the
ui_test_subtree_sync
branch
2 times, most recently
from
4aaeef1
to
5ad74b0
Compare
Ok I guess we'll always to squash merges when pulling |
What do you mean by this? |
RalfJung
added
the
S-waiting-on-author
when we do a sync with the ui_test repo, we'll only see a single sync commit instead of all the commits that happened on the ui_test side. |
|
Aha... So the usual process does not work? Why?
Anyway I dont think I care strongly about reflecting ui-test history in this repo. Please just add a section to the contributor docs saying exactly which commands one has to run for a sync.
Alternatively, we could just use a cargo git dependency pinned to a particular commit? Or would that make the rustc workspace unhappy?
|
I think because subtree doesn't really work nicely for moving a subfolder out, it is meant for moving a separate repo into a subfolder. |
We could just point to a regular crates.io dependency |
|
Or, that too. You could give me access so I can publish new versions if needed. |
oli-obk
force-pushed
the
ui_test_subtree_sync
branch
from
2dc5f49
to
a33fb11
Compare
|
You should have an invite |
RalfJung
changed the title
|
(changed PR title to match) |
|
That repo having its last commit 28 days ago, it probably needs to be synced again? |
all tests passed, so I assumed everything necessary was there, but I'll do the push on master before merging this |
|
At least #2505 is not included. |
|
published 0.1.1 with the latest changes. |
|
I confirmed they are in sync. Thanks :) @bors r+ |
Use ui_test from crates.io instead of having it in-tree I have moved a copy of the `ui_test` crate into [a separate repo](https://github.com/oli-obk/ui_test) to facilitate the further non-miri development of it. I will keep syncing until we have reached a point where we don't touch it anymore for miri. At that point we can remove the in-tree version and do further development out of tree.
|
@bors r- retry |
oli-obk
force-pushed
the
ui_test_subtree_sync
branch
from
a33fb11
to
fb071a1
Compare
|
@bors r=RalfJung |
|
☀️ Test successful - checks-actions |
I have moved a copy of the
ui_testcrate into a separate repo to facilitate the further non-miri development of it. I will keep syncing until we have reached a point where we don't touch it anymore for miri. At that point we can remove the in-tree version and do further development out of tree.