Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SSE3 and SSSE3 intrinsics #3086

Merged
merged 2 commits into from Sep 30, 2023
Merged

Implement SSE3 and SSSE3 intrinsics #3086

merged 2 commits into from Sep 30, 2023

Conversation

eduardosm
Copy link
Contributor

No description provided.

saethlin
saethlin reviewed Sep 27, 2023
View reviewed changes
src/shims/x86/mod.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Sep 29, 2023
View reviewed changes
src/shims/x86/mod.rs Show resolved Hide resolved
src/shims/x86/mod.rs Outdated Show resolved Hide resolved
src/shims/x86/sse3.rs Outdated Show resolved Hide resolved
src/shims/x86/sse3.rs Outdated Show resolved Hide resolved
src/shims/x86/ssse3.rs Show resolved Hide resolved
tests/pass/intrinsics-x86-sse3-ssse3.rs Show resolved Hide resolved
src/shims/x86/ssse3.rs Show resolved Hide resolved
src/shims/x86/ssse3.rs Show resolved Hide resolved
src/shims/x86/ssse3.rs Show resolved Hide resolved
src/shims/x86/ssse3.rs Show resolved Hide resolved
RalfJung
RalfJung reviewed Sep 29, 2023
View reviewed changes
src/shims/x86/sse3.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

@rustbot author

@rustbot rustbot added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Sep 29, 2023
@eduardosm
Copy link
Contributor Author

Some conversations were hidden by github and I have just seem them now 🤦🏻‍♂️

@eduardosm
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Sep 29, 2023
@RalfJung
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Sep 30, 2023
@eduardosm
Copy link
Contributor Author

@rustbot ready

I also squashed everything into two commits

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Sep 30, 2023
@RalfJung
Copy link
Member

Thanks a lot!
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 30, 2023

📌 Commit d8b4611 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 30, 2023

⌛ Testing commit d8b4611 with merge 574f234...

@bors
Copy link
Collaborator

bors commented Sep 30, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 574f234 to master...

@bors bors merged commit 574f234 into rust-lang:master Sep 30, 2023
8 checks passed
@eduardosm eduardosm deleted the x86-sse3-intrinsics branch September 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@saethlin saethlin saethlin left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Waiting for a review to complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eduardosm @RalfJung @bors @saethlin @rustbot