Implement round.ps and round.pd SSE4.1 intrinsics #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Nov 12, 2023
tests/pass/intrinsics-x86-sse41.rs
Outdated
Comment on lines
268
to
270
| test(-1.5, -2.0); | ||
| test(-1.25, -1.0); | ||
| test(-1.75, -2.0); |
To make sure the rounding direction is working as expected
eduardosm
force-pushed
the
sse41-round
branch
from
1b79fc2
to
598ed6b
Compare
|
Looks good, thanks! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had forgotten them.
I also increased the coverage of rounding tests to make sure the rounding direction is working as expected (e.g. test
1.25,1.5,1.75...).