Implement all 16 AVX compare operators for 128-bit SIMD vectors #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Nov 19, 2023
RalfJung
reviewed
Nov 19, 2023
RalfJung
reviewed
Nov 19, 2023
RalfJung
reviewed
Nov 19, 2023
RalfJung
reviewed
Nov 19, 2023
RalfJung
reviewed
Nov 19, 2023
RalfJung
reviewed
Nov 20, 2023
| // Bit 4 specifies whether the operation is quiet or signaling, which | ||
| // we do not care in Miri. | ||
| // Bits 0..=2 specifies the operation. | ||
| let (gt, lt, eq, unord) = match imm & 0b111 { |
There was a problem hiding this comment.
Suggested change
| let (gt, lt, eq, unord) = match imm & 0b111 { | |
| // `gt` indicates the result to be returned when the LHS is strictly greater than the RHS, and so on. | |
| let (gt, lt, eq, unord) = match imm & 0b111 { |
`_mm_cmp_{ss,ps,sd,pd}` functions are AVX functions that use `llvm.x86.sse{,2}` prefixed intrinsics, so they were "accidentally" partially implemented when SSE and SSE2 intrinsics were implemented.
The 16 AVX compare operators are now implemented and tested.
|
Awesome, thanks! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mm_cmp_{ss,ps,sd,pd}functions are AVX functions that usellvm.x86.sse{,2}.prefixed intrinsics, so they were "accidentally" partially implemented when SSE and SSE2 intrinsics were implemented.The 16 AVX compare operators are now implemented and tested.