Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit the AllocIds and BorTags in borrow state FrameExtra #3229

Merged
merged 1 commit into from Dec 17, 2023

Conversation

saethlin
Copy link
Member

Fixes #3228

I said

The obvious way would be to visit the AllocIds in borrow_tracker::FrameExtra in the GC.

Since I have had no new ideas, that's what this does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the issue that explains why this is tested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 17, 2023

📌 Commit f82a1c2 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 17, 2023

⌛ Testing commit f82a1c2 with merge 02880d3...

@bors
Copy link
Collaborator

bors commented Dec 17, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 02880d3 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Dec 17, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 02880d3 to master...

@bors bors merged commit 02880d3 into rust-lang:master Dec 17, 2023
8 checks passed
@saethlin saethlin deleted the protector-gc-ice branch December 17, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provenance GC causes dead_alloc_map ICE when a protector is the last mention of an AllocId
3 participants