Implement the mmap64 foreign item.
#3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/mmap64
branch
2 times, most recently
from
d5d3e99
to
06bdcfc
Compare
`mmap64` is like `mmap` but uses a 64-bit integer instead of `off_t` for the offset parameter.
sunfishcode
force-pushed
the
sunfishcode/mmap64
branch
from
06bdcfc
to
3fdb685
Compare
|
Can we avoid a copy+paste of all the mmap tests by doing something like |
|
@rustbot author |
rustbot
added
the
S-waiting-on-author
RalfJung
reviewed
Feb 10, 2024
`mmap64` is only defined on Linux, so move the implementation to Linux-specific code.
RalfJung
reviewed
Feb 11, 2024
| @@ -217,6 +218,14 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriInterpCxExt<'mir, 'tcx> { | |||
| this.write_null(dest)?; | |||
| } | |||
|
|
|||
| "mmap64" => { | |||
There was a problem hiding this comment.
You put this into the category of
// Incomplete shims that we "stub out" just to get pre-main initialization code to work.
// These shims are enabled only when the caller is in the standard library.
That doesn't seem right.
There was a problem hiding this comment.
I didn't notice that comment :-). I've now moved it to "File related shims".
|
Thanks! |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap64is likemmapbut uses a 64-bit integer instead ofoff_tfor the offset parameter.