Windows miri-script execution egronomics #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Feb 24, 2024
RalfJung
reviewed
Feb 24, 2024
|
Thanks! None of us on the team use Windows so it's hard for us to even know where the issues are, let alone how to fix them. :) In the future it'd be good to actually use this on CI (CI is a bash script even on Windows so I assume this script is not used there), but that doesn't have to happen for this PR. |
This allows for Windows users to use miri-script without pain
RossSmyth
force-pushed
the
windows-script
branch
from
dc3917d
to
c5872cb
Compare
|
Good idea, I'll open a PR with CI later. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for Windows users to use miri-script without pain. As working on miri earlier I was doing
.\miri-script\target\debug\miri-script.exe { install | build | ... }which wasn't fun.