Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the ability to disable ABI checking #3340

Merged
merged 1 commit into from Mar 6, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 2, 2024

This got deprecated in #3071, about half a year ago.

@rust-lang/miri I think it's fine to remove this now.

@saethlin
Copy link
Member

saethlin commented Mar 2, 2024

Agreed.

@bors
Copy link
Collaborator

bors commented Mar 2, 2024

☔ The latest upstream changes (presumably #3338) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung
Copy link
Member Author

RalfJung commented Mar 6, 2024

@oli-obk what do you think? :)

@oli-obk
Copy link
Contributor

oli-obk commented Mar 6, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2024

📌 Commit 6e4530c has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 6, 2024

⌛ Testing commit 6e4530c with merge ef2ae90...

@bors
Copy link
Collaborator

bors commented Mar 6, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ef2ae90 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 6, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ef2ae90 to master...

@bors bors merged commit ef2ae90 into rust-lang:master Mar 6, 2024
8 checks passed
@RalfJung RalfJung deleted the no-disable-abi-check branch March 6, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants