Windows: support getting the thread name #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Mar 3, 2024
Windows: support getting the thread name Also organize the thread name tests a bit.
ChrisDenton
reviewed
Mar 3, 2024
src/shims/windows/foreign_items.rs
Outdated
| Some(Handle::Pseudo(PseudoHandle::CurrentThread)) => this.get_active_thread(), | ||
| _ => this.invalid_handle("SetThreadDescription")?, | ||
| }; | ||
| // FIXME what is the right default thread name? Or should we raise an error? |
There was a problem hiding this comment.
The right default would be an empty string. Though in std that would be changed to <unnamed> anyways.
There was a problem hiding this comment.
So on actual Windows it succeeds and returns an empty string when no name was that?
That's easy enough to do. Is this documented anywhere?
Yeah I know this is not observable on std.
There was a problem hiding this comment.
Is this documented anywhere?
No.
RalfJung
force-pushed
the
win-get-thread-name
branch
from
4fdabe4
to
bef7237
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also organize the thread name tests a bit.