Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support f*_algebraic #3596

Merged
merged 1 commit into from
May 11, 2024
Merged

support f*_algebraic #3596

merged 1 commit into from
May 11, 2024

Conversation

bend-n
Copy link
Contributor

@bend-n bend-n commented May 11, 2024 •
edited

supports the f*_algebraic intrinsics.

@RalfJung
Copy link
Member

Thanks!

This should use adjust_nan to avoid making any guarantees about the NaNs being returned.

Ideally, we'd also not return the exact result but perturb it a bit, to drive home the point that these operations are non-deterministic. But the existing fast-math intrinsics don't do that either so we can leave that to #3555.

RalfJung
RalfJung reviewed May 11, 2024
View reviewed changes
tests/pass/float_algebraic_math.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the test into the tests/pass/intrinsics folder.

@bend-n
Copy link
Contributor Author

bend-n commented May 11, 2024

This should use adjust_nan to avoid making any guarantees about the NaNs being

the comment on f*_fast says that wrapping_binary_op already calls generate_nan?

@RalfJung
Copy link
Member

RalfJung commented May 11, 2024 •
edited

the comment on f*_fast says that wrapping_binary_op already calls generate_nan?

Ah, you're right, thanks!

@RalfJung
Copy link
Member

Thanks, looks good. :)

Please squash the commits.

@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 11, 2024

📌 Commit 18379e8 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 11, 2024

⌛ Testing commit 18379e8 with merge 24fc363...

@bors
Copy link
Collaborator

bors commented May 11, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 24fc363 to master...

@bors bors merged commit 24fc363 into rust-lang:master May 11, 2024
8 checks passed
@bend-n bend-n deleted the support_fstar_algebraic branch May 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bend-n @RalfJung @bors