-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give FileDescription::{read, write}
access to the MiriInterpCx
#3603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks! Just some nits.
.map(|c| i64::try_from(c).unwrap()); | ||
drop(file_descriptor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its still good to keep the FD for as short as possible, so please keep the drop
around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, fixed.
Looks good! Please squash the commits. |
poll :) |
No, there's not, github just doesn't notify on all force pushes (only on some) so I didn't realize you had done the squashing. Thanks! @bors r+ |
☀️ Test successful - checks-actions |
fixes #3572