Fix wrong lifetime of TyCtxt #773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also update the |
|
Done. |
|
Awesome, thanks a lot. :) I was just starting to do this update myself, but you were faster. :D |
|
Oh dang. We can't land this because CI fails until rust-lang/rust#61828 has landed. Argh, those dependency chains. :/ |
|
Most likely that PR will not make it into the next nightly so we can only land this one here on Sunday, meaning the "latest available Miri" will be broken until at least Monday. :( |
|
Ah, I can make a Rust PR with an unmerged branch. So I updated rust-lang/rust#61828 to includes this. Please don't force-push or we will all be confused! |
|
Ok sure! |
Merged
|
I made this PR part of #775, to make sure we don't get a stale submodule in the rustc repo. Thanks again for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustup rust-lang/rust#61817