Use the upstream exact_div implementation
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Oct 9, 2019
RalfJung
force-pushed
the
exact_div_reuse
branch
from
2152ca7
to
47bfd84
Compare
RalfJung
reviewed
Nov 3, 2019
| @@ -1,5 +1,5 @@ | |||
| #![feature(core_intrinsics)] | |||
| fn main() { | |||
| // signed divison with a remainder | |||
| unsafe { std::intrinsics::exact_div(-19i8, 2); } //~ ERROR Scalar(0xed) cannot be divided by Scalar(0x02) without remainder | |||
| unsafe { std::intrinsics::exact_div(-19i8, 2); } //~ ERROR 237 cannot be divided by 2 without remainder | |||
There was a problem hiding this comment.
@oli-obk I am not sure if this is the desired printing here... we are printing a negative number as a positive one.
|
@bors r+ |
|
📌 Commit fcf0f88 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 3, 2019
Use the upstream `exact_div` implementation introduced in rust-lang/rust#63810
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in rust-lang/rust#63810