Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port basics of .travis.yml to GitHub Actions #126

Merged
merged 3 commits into from
Oct 24, 2021

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Oct 24, 2021

"master doc to gh-pages" has not been ported yet for example, but having the
basics work will certainly be better than having nothing.

"master doc to gh-pages" has not been ported yet for example, but having the
basics work will certainly be better than having nothing.
@Enselic
Copy link
Member Author

Enselic commented Oct 24, 2021

Example run: https://github.com/Enselic/pkg-config-rs/pull/1/checks

Fails on Rust 1.30 because of #123 (comment), but I'm not sure if you want to fix the code or bump MSRV, so I just left it as this for now.

@Enselic
Copy link
Member Author

Enselic commented Oct 24, 2021

I see here now that you prefer to change the code over bumping MSRV, so I will leave it at Rust 1.30.

@sdroege
Copy link
Collaborator

sdroege commented Oct 24, 2021

"master doc to gh-pages" has not been ported yet for example

That also seems rather unnecessary at this point as the docs are on docs.rs anyway :)

but having the > basics work will certainly be better than having nothing.

As Travis is completely broken, can you also remove the .travis.yml here? It's not useful anyway. And change the "build" badge in the README.md to the corresponding one from the GitHub Actions?

Seems all good to me otherwise, thanks a lot!

It is of no use now that we have .github/workflows/ci.yml.
@Enselic
Copy link
Member Author

Enselic commented Oct 24, 2021

As Travis is completely broken, can you also remove the .travis.yml here? It's not useful anyway. And change the "build" badge in the README.md to the corresponding one from the GitHub Actions?

Done and done. (You can confirm the badge URL is correct by replacing "rust-lang" with "Enselic" to get the badge of my fork: https://github.com/Enselic/pkg-config-rs/actions/workflows/ci.yml/badge.svg)

Happy to help!

@sdroege sdroege merged commit 8f7ade8 into rust-lang:master Oct 24, 2021
@sdroege
Copy link
Collaborator

sdroege commented Oct 24, 2021

Thanks! I'll upload a new release to crates.io with the 1.30 fix later.

@Enselic Enselic deleted the basic-github-actions-port branch October 24, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants