Add support for MSVC #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this building glib-sys and it seems to work properly. |
sdroege
reviewed
Jul 18, 2018
src/lib.rs
Outdated
| @@ -410,6 +393,10 @@ impl Config { | |||
| if self.is_static(name) { | |||
| cmd.arg("--static"); | |||
| } | |||
| let target = env::var("TARGET").unwrap_or_else(|_| String::new()); | |||
| if target.contains("msvc") { | |||
There was a problem hiding this comment.
Why not
if let Some(target) = env::var("TARGET") {
if target.contains("msvc") {
cmd.arg("--msvc-syntax");
}
}or something with match and guards for the contains?
One level of indentation more, but doesn't have the empty string, which seems a bit ugly to me
|
Thanks! |
|
@alexcrichton Thanks! Can you prepare a new release with that change? |
|
Sure thing, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59