This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Move Upvar lowering from THIR to MIR #25
Comments
This was referenced Nov 17, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Nov 19, 2020
Move capture lowering from THIR to MIR This allows us to: - Handle precise Places captured by a closure directly in MIR. Handling captures in MIR is easier since we can rely on/ tweak PlaceBuilder to generate `mir::Place`s that resemble how we store captures (`hir::Place`). - Handle `let _ = x` case when feature `capture_disjoint_fields` is enabled directly in MIR. This is required to be done in MIR since patterns are desugared in MIR. Closes: rust-lang/project-rfc-2229#25 r? `@nikomatsakis`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Nov 19, 2020
Move capture lowering from THIR to MIR This allows us to: - Handle precise Places captured by a closure directly in MIR. Handling captures in MIR is easier since we can rely on/ tweak PlaceBuilder to generate `mir::Place`s that resemble how we store captures (`hir::Place`). - Handle `let _ = x` case when feature `capture_disjoint_fields` is enabled directly in MIR. This is required to be done in MIR since patterns are desugared in MIR. Closes: rust-lang/project-rfc-2229#25 r? ``@nikomatsakis``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Nov 19, 2020
Move capture lowering from THIR to MIR This allows us to: - Handle precise Places captured by a closure directly in MIR. Handling captures in MIR is easier since we can rely on/ tweak PlaceBuilder to generate `mir::Place`s that resemble how we store captures (`hir::Place`). - Handle `let _ = x` case when feature `capture_disjoint_fields` is enabled directly in MIR. This is required to be done in MIR since patterns are desugared in MIR. Closes: rust-lang/project-rfc-2229#25 r? ```@nikomatsakis```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We lower paths that start from an
Upvarhere.Essentially what this code does is convert upvars to refer to a field within the desugared
ClosureSubsts. We want to refactor this code as follows:Thir::Expr::UpvarRef(var_hir_id)in case the var_hir_id is mentioned within the closure. (This will allow us to deal with thelet _ = xproblem in MIR).convert_vartorustc_mir_build/as_placeThir::Expr::SelfRef, it's most likely only for Closures.The text was updated successfully, but these errors were encountered: