Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Move out of reference in move closures #31

Closed
arora-aman opened this issue Dec 3, 2020 · 4 comments · Fixed by rust-lang/rust#82007
Closed

Move out of reference in move closures #31

arora-aman opened this issue Dec 3, 2020 · 4 comments · Fixed by rust-lang/rust#82007
Assignees
@arora-aman
Labels
bug Something isn't working
Projects
RFC-2229
Milestone
Feature complete

Comments

@arora-aman
Copy link
Member

arora-aman commented Dec 3, 2020 •
edited
Loading 

struct S {
    x: String,
    y: String
}

fn x(s: &mut S) {
    let mut c = move || {
        s.x.truncate(0);
    };
    c();
}


fn main() {
    let mut s = S { x: "".into(), y: "".into() };
    x(&mut s);
}

Without the feature gate s which is a &mut S is moved. However with the feature gate *s.x is moved which is a String which behind a &mut S and can't be moved out.
@arora-aman arora-aman added this to To-do in RFC-2229 via automation Dec 3, 2020
@nikomatsakis
Copy link
Contributor

notes: https://hackmd.io/CdxyYchnRfyIxZHeykyvoA

@arora-aman
Copy link
Member Author

Update from 2229 sync meeting:

  • We drop any Derefs in case of move closures.

@arora-aman arora-aman added the bug Something isn't working label Dec 4, 2020
@arora-aman arora-aman moved this from To-do to In progress in RFC-2229 Dec 4, 2020
@arora-aman arora-aman self-assigned this Dec 7, 2020
@arora-aman arora-aman moved this from In progress to In review in RFC-2229 Dec 17, 2020
@arora-aman arora-aman moved this from In review to In progress in RFC-2229 Jan 23, 2021
@arora-aman
Copy link
Member Author

https://hackmd.io/PzxYMPY4RF-B9iH9uj9GTA

@arora-aman
Copy link
Member Author

First part implemented here: rust-lang/rust#80092

@arora-aman arora-aman moved this from In progress to In review in RFC-2229 Feb 11, 2021
@arora-aman arora-aman mentioned this issue Feb 11, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 16, 2021
@Dylan-DPC
Rollup merge of rust-lang#82007 - sexxi-goose:reborrow, r=nikomatsakis
5cb3ffe 
Implement reborrow for closure captures

The strategy for captures is detailed here with examples: https://hackmd.io/PzxYMPY4RF-B9iH9uj9GTA

Key points:
- We only need to reborrow a capture in case of move closures.
  - If we mutate something via a `&mut` we store it as a `MutBorrow`/`UniqueMuBorrow` of the path containing the `&mut`,
  - Similarly, if it's read via `&` ref we just store it as a `ImmBorrow` of the path containing the `&` ref.
  - If a path doesn't deref a `&mut`, `&`, then that path is captured by Move.
  - If the use of a path results in a move when the closure is called, then that path is truncated before any deref and the truncated path is moved into the closure.

- In the case of non-move closure if a use of a path results in a move, then the path is truncated before any deref and the truncated path is moved into the closure.

Note that the implementation differs a bit from the document to allow for truncated path to be used in the ClosureKind analysis that happens as part of the first capture analysis pass.

Closes: rust-lang/project-rfc-2229#31

r? `@nikomatsakis`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 16, 2021
@Dylan-DPC
Rollup merge of rust-lang#82007 - sexxi-goose:reborrow, r=nikomatsakis
7e8d0c6 
Implement reborrow for closure captures

The strategy for captures is detailed here with examples: https://hackmd.io/PzxYMPY4RF-B9iH9uj9GTA

Key points:
- We only need to reborrow a capture in case of move closures.
  - If we mutate something via a `&mut` we store it as a `MutBorrow`/`UniqueMuBorrow` of the path containing the `&mut`,
  - Similarly, if it's read via `&` ref we just store it as a `ImmBorrow` of the path containing the `&` ref.
  - If a path doesn't deref a `&mut`, `&`, then that path is captured by Move.
  - If the use of a path results in a move when the closure is called, then that path is truncated before any deref and the truncated path is moved into the closure.

- In the case of non-move closure if a use of a path results in a move, then the path is truncated before any deref and the truncated path is moved into the closure.

Note that the implementation differs a bit from the document to allow for truncated path to be used in the ClosureKind analysis that happens as part of the first capture analysis pass.

Closes: rust-lang/project-rfc-2229#31

r? ``@nikomatsakis``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 17, 2021
@Dylan-DPC
Rollup merge of rust-lang#82007 - sexxi-goose:reborrow, r=nikomatsakis
f5417bd 
Implement reborrow for closure captures

The strategy for captures is detailed here with examples: https://hackmd.io/PzxYMPY4RF-B9iH9uj9GTA

Key points:
- We only need to reborrow a capture in case of move closures.
  - If we mutate something via a `&mut` we store it as a `MutBorrow`/`UniqueMuBorrow` of the path containing the `&mut`,
  - Similarly, if it's read via `&` ref we just store it as a `ImmBorrow` of the path containing the `&` ref.
  - If a path doesn't deref a `&mut`, `&`, then that path is captured by Move.
  - If the use of a path results in a move when the closure is called, then that path is truncated before any deref and the truncated path is moved into the closure.

- In the case of non-move closure if a use of a path results in a move, then the path is truncated before any deref and the truncated path is moved into the closure.

Note that the implementation differs a bit from the document to allow for truncated path to be used in the ClosureKind analysis that happens as part of the first capture analysis pass.

Closes: rust-lang/project-rfc-2229#31

r? ```@nikomatsakis```
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 17, 2021
@Dylan-DPC
Rollup merge of rust-lang#82007 - sexxi-goose:reborrow, r=nikomatsakis
0b2f2b9 
Implement reborrow for closure captures

The strategy for captures is detailed here with examples: https://hackmd.io/PzxYMPY4RF-B9iH9uj9GTA

Key points:
- We only need to reborrow a capture in case of move closures.
  - If we mutate something via a `&mut` we store it as a `MutBorrow`/`UniqueMuBorrow` of the path containing the `&mut`,
  - Similarly, if it's read via `&` ref we just store it as a `ImmBorrow` of the path containing the `&` ref.
  - If a path doesn't deref a `&mut`, `&`, then that path is captured by Move.
  - If the use of a path results in a move when the closure is called, then that path is truncated before any deref and the truncated path is moved into the closure.

- In the case of non-move closure if a use of a path results in a move, then the path is truncated before any deref and the truncated path is moved into the closure.

Note that the implementation differs a bit from the document to allow for truncated path to be used in the ClosureKind analysis that happens as part of the first capture analysis pass.

Closes: rust-lang/project-rfc-2229#31

r? ````@nikomatsakis````
RFC-2229 automation moved this from In review to Done Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arora-aman arora-aman

Labels
bug Something isn't working
Projects
RFC-2229
  
Done
Milestone
Feature complete
Development

Successfully merging a pull request may close this issue.

Implement reborrow for closure captures sexxi-goose/rust
2 participants
@nikomatsakis @arora-aman