This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Propose more relaxtions to closure catpures #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breif details about implementation: - Instead of pre-initializing `closure_captured` and `upvars_capture_map` using `upvars_mentioned` we will be rely on use within the closure. This will be handled as part of #7 - For coercing a closure to FnPtr, instead of relying on `upvars_mentioned` in typechk we will accept such code in typechk while setting a no-capture obligation that will be validated in trait selection post capture analysis.
|
Once this is accepted here, we probably want to open an issue on rust-lang/rust as well |
arora-aman
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptually this is a result of capturing based on the use of variables from the enclosing environment of the closure instead of based on variables that appear within the closure.
Breif details about implementation:
closure_captures,upvars_capture_mapandClosureSubstsusingupvars_mentionedwe will rely on expressions/ Places being used within the closure. This will be handled as part of Use hir::Place in closure_captures #7 Always make the "upvar types" a tuple of the actual upvar types (Parent issue#53488) #4upvars_mentionedin typechk we will accept such code in typechk while setting a no-capture obligation that will be validated in trait selection post capture analysis.Rendered
cc: @rust-lang/wg-rfc-2229