[disabled] Remove unused files from the release #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
force-pushed
the
prune-unused-files
branch
from
eb4f200
to
c26ca8d
Compare
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our releases currently include a bunch of "internal" files that are not useful for our downstream users but that happen to be stored in the artifacts bucket, such as CPU graphs, the
build-manifestcomponent, and similar. This PR implements purging them before shipping the release, by only retaining the files mentioned in the manifest, the files generated bybuild-manifestor the files matching a pattern explicitly allowed bypromote-release.This feature only works on rustc branches that include rust-lang/rust#78196, and is currently disabled. To enable it the
PROMOTE_RELEASE_WIP_PRUNE_UNUSED_FILESenvironment variable needs to be set. My current plan is to merge this, run a dev release with this feature enable, compare the result with the prod release, and then either fix the bugs or enable the feature by default (removing the flag).r? @Mark-Simulacrum