Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug variance link #1228

Closed
wants to merge 2 commits into from
Closed

Conversation

lengyijun
Copy link

@lengyijun lengyijun commented Jun 10, 2022

I find src/test/ui/variance/variance-types.rs quite helpful in debugging variance.
I want to put the link into the book.

I find `src/test/ui/variance/variance-regions-direct.rs` quite helpful in debugging variance.
I want to put the link into the book.
@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2022

Thanks for the PR! I think I would prefer to not include something that points to rustc's testsuite in this way. Also, the reference isn't oriented towards in-depth illustrations into concepts like this. The nomicon is usually the place for things like that, and it has a chapter on variance. If the examples there are not illustrative enough, then I think it would be worthwhile to consider adding more code examples there (inline, not linked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants