Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACKING.md seems to be out of date #1058

Closed
BurntSushi opened this issue Aug 1, 2023 Discussed in #1057 · 1 comment
Closed

HACKING.md seems to be out of date #1058

BurntSushi opened this issue Aug 1, 2023 Discussed in #1057 · 1 comment

Comments

@BurntSushi
Copy link
Member

Discussed in #1057

Originally posted by aochagavia August 1, 2023
I was going through HACKING.md and realized there is some text related to benchmarks that is no longer accurate. Since the file was touched 4 years ago, there might be other things that need updating too.

I'm opening this here because none of the available issue categories seemed fitting.

@BurntSushi
Copy link
Member Author

Yes, indeed, it is outdated. The entire internals were rewritten but I didn't update this document. It probably needs to be completely rewritten.

If you were curious about benchmarks, then see https://github.com/BurntSushi/rebar for more than you could ever possibly want.

BurntSushi added a commit that referenced this issue Oct 8, 2023
It is almost completely wrong now. Instead of rewriting it---which would
be a huge endeavor---we just point folks toward my blog on regex
internals.

Closes #1058
BurntSushi added a commit that referenced this issue Oct 9, 2023
It is almost completely wrong now. Instead of rewriting it---which would
be a huge endeavor---we just point folks toward my blog on regex
internals.

Closes #1058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant