-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make case insensitive comparisons better #55
Comments
This is a very hacky fix to handling case insensitivity. It preserves existing behavior by checking the first character returned by the {upper,lower}case iterators. We should switch from equality comparison to "does this character match *any* character in the {upper,lower}case iterator." See #55.
For what it’s worth, in ES6, a regex with both Either way, case folding (for caseless matching) is not the quite as either lower-case or upper-case. I didn’t manage to find a spec for what Perl does exactly (though I didn’t search very hard). The Python documentation is equally unhelpful. |
We should switch from equality comparison on the first character returned by
{upper,lower}case
iterators to "does this character match any character in the{upper,lower}case
iterator."The text was updated successfully, but these errors were encountered: